Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimade Materials Doc #230

Merged
merged 4 commits into from
Jul 20, 2021
Merged

Optimade Materials Doc #230

merged 4 commits into from
Jul 20, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jul 20, 2021

Adds the ability to built optimade compatible StructureResource collection

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #230 (14a942c) into main (03592ab) will decrease coverage by 3.78%.
The diff coverage is 89.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #230      +/-   ##
==========================================
- Coverage   95.33%   91.54%   -3.79%     
==========================================
  Files          25       40      +15     
  Lines        1736     2791    +1055     
==========================================
+ Hits         1655     2555     +900     
- Misses         81      236     +155     
Impacted Files Coverage Δ
emmet-builders/emmet/builders/vasp/materials.py 81.51% <52.77%> (ø)
emmet-core/emmet/core/vasp/validation.py 85.71% <82.75%> (-3.02%) ⬇️
...s/emmet/builders/materials/electronic_structure.py 85.84% <85.84%> (ø)
emmet-builders/emmet/builders/materials/summary.py 87.71% <87.71%> (ø)
emmet-core/emmet/core/summary.py 88.18% <88.18%> (ø)
emmet-core/emmet/core/provenance.py 93.97% <88.63%> (-2.80%) ⬇️
emmet-core/emmet/core/optimade.py 90.00% <90.00%> (ø)
emmet-core/emmet/core/utils.py 91.04% <90.90%> (+13.62%) ⬆️
emmet-core/emmet/core/settings.py 96.15% <91.66%> (+7.02%) ⬆️
emmet-core/emmet/core/oxidation_states.py 92.68% <92.68%> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2af317...14a942c. Read the comment docs.

@shyamd shyamd merged commit 33d002c into main Jul 20, 2021
@shyamd shyamd deleted the optimade branch August 27, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants