Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EmmetBaseModel #235

Merged
merged 6 commits into from
Jul 22, 2021
Merged

New EmmetBaseModel #235

merged 6 commits into from
Jul 22, 2021

Conversation

shyamd
Copy link
Contributor

@shyamd shyamd commented Jul 22, 2021

This PR adds a new EmmetBaseModel for documents to inherit from so that certain fields are always present at the top level. This is recommended for top-level document models and not for sub-fields.

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2021

Codecov Report

Merging #235 (9060dfc) into main (33d002c) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   91.54%   91.58%   +0.04%     
==========================================
  Files          40       41       +1     
  Lines        2791     2805      +14     
==========================================
+ Hits         2555     2569      +14     
  Misses        236      236              
Impacted Files Coverage Δ
emmet-core/emmet/core/base.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/optimade.py 90.19% <100.00%> (+0.19%) ⬆️
emmet-core/emmet/core/structure.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/structure_group.py 95.32% <100.00%> (ø)
emmet-core/emmet/core/stubs.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/task.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/vasp/validation.py 85.88% <100.00%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33d002c...9060dfc. Read the comment docs.

@shyamd shyamd merged commit 58881a4 into main Jul 22, 2021
@shyamd shyamd deleted the base-emmet-model branch July 22, 2021 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants