Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation data added to PropertyDoc #247

Merged
merged 4 commits into from
Aug 19, 2021

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Aug 19, 2021

Deprecated fields added to PropertyDoc to allow for deprecation on a property-by-property basis for relevant collections built from materials.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2021

Codecov Report

Merging #247 (d82ab68) into main (bd27fdb) will increase coverage by 0.00%.
The diff coverage is 92.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #247   +/-   ##
=======================================
  Coverage   91.71%   91.72%           
=======================================
  Files          43       43           
  Lines        2862     2865    +3     
=======================================
+ Hits         2625     2628    +3     
  Misses        237      237           
Impacted Files Coverage Δ
...s/emmet/builders/materials/electronic_structure.py 85.84% <ø> (ø)
emmet-core/emmet/core/summary.py 88.18% <ø> (-0.11%) ⬇️
emmet-core/emmet/core/electronic_structure.py 95.23% <76.92%> (ø)
emmet-core/emmet/core/provenance.py 94.04% <93.33%> (ø)
...lders/emmet/builders/materials/oxidation_states.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/material_property.py 100.00% <100.00%> (ø)
emmet-core/emmet/core/oxidation_states.py 92.85% <100.00%> (ø)
emmet-core/emmet/core/thermo.py 90.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedcf9c...d82ab68. Read the comment docs.

@munrojm munrojm merged commit 380cfc3 into materialsproject:main Aug 19, 2021
@shyamd
Copy link
Contributor

shyamd commented Aug 20, 2021

Very cool!

@munrojm munrojm deleted the deprecation_data branch September 2, 2021 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants