fixed deserialization of phase diagrams #2522
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON reconstruction bug:
The problem is: Because MSONables from_dict was replaced, there is no recursive reconstruction of the objects when you hit
el_ref
. When you doas_dict
->from_dict
in python everything looks fine.but the object was never completely serialized.
If you completely serialized it like putting it into as json file or database then you cannot reconstruct the phase diagram.