Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI errors #2940

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Fix CI errors #2940

merged 7 commits into from
Apr 18, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Apr 17, 2023

Not sure when these errors first started showing. Fixed in

>       state_data = mixing_scheme_no_compat.get_mixing_state_data(ms_scan_only.all_entries, verbose=True)
E       TypeError: MaterialsProjectDFTMixingScheme.get_mixing_state_data() got an unexpected keyword argument 'verbose'

pymatgen/entries/tests/test_mixing_scheme.py:1359: TypeError
seems to have been caused by test_edge_editing(), now using deep copy instead in-place edit
@janosh janosh changed the title Bump mypy to v1.2.0 Fix CI errors Apr 17, 2023
@janosh janosh enabled auto-merge (squash) April 17, 2023 23:46
@janosh janosh added the fix Bug fix PRs label Apr 17, 2023
@janosh janosh merged commit e4b4ea7 into master Apr 18, 2023
@janosh janosh deleted the mypy-1.2 branch April 18, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant