Lookup MPRester API key in settings if None provided as arg - #3004
Merged
Conversation
janosh
enabled auto-merge (squash)
May 21, 2023 22:26
Member
|
For the new Rester, reading the API key from - MPRester(None)
+ MPRester()Thanks for making the upper case work as well @ml-evs! |
lbluque
pushed a commit
to lbluque/pymatgen
that referenced
this pull request
May 23, 2023
…rialsproject#3004) * Lookup `MPRester` API key in settings if `None` provided as arg * shorten MPRester doc str * add MPResterOldTest.test_api_key_is_none() --------- Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both the new and legacy versions of
MPResteracceptedapi_key=Noneto be passed as an argument, triggering a fallback to the settings version of the key. The new behavior of the dynamicMPResteris to attempt to use theNonevalue directly, i.e., without checking for an externally configured value.This PR simply adjusts the behavior so that
api_key=Nonewill still trigger a settings lookup.