Unskip and fix packmol tests - #3195
Merged
Merged
Conversation
….tmp_path auto-used fixture
…talled
pymatgen/io/tests/test_packmol.py:188:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
args = (<pymatgen.analysis.molecule_matcher.MoleculeMatcher object at 0x2aecc7bd0>,)
kwargs = {}
@functools.wraps(_callable)
def decorated(*args, **kwargs):
if not self.condition:
> raise RuntimeError(self.message)
E RuntimeError: BabelMolAdaptor requires openbabel to be installed with Python bindings. Please get it at http://openbabel.org (version >=3.0.0).
was set to always skip
janosh
added
tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
60ff0cb don't use tempfile.TemporaryDirectory() in tests, prefer PymatgenTest.tmp_path auto-used fixture
b8a0f63 fix broken test_files paths in TestPackmolSet
2013d15 skip failing TestPackmolSet.test_random_seed due to openbabel not installed
b3c6150 only skip pymatgen/io/tests/test_packmol.py if packmol not installed