Skip to content

Move PymatgenTest.TEST_FILES_DIR attribute into module scope #3227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 6, 2023

Conversation

janosh
Copy link
Member

@janosh janosh commented Aug 6, 2023

e734bf3 fix IonEntry doc str + type hints
66d0043 move TEST_FILES_DIR attr from PymatgenTest into module scope
ca3c9e3 PymatgenTest.TEST_FILES_DIR -> TEST_FILES_DIR

@janosh janosh added the tests Issues with or changes to the pymatgen test suite label Aug 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2023

Codecov Report

Attention: Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 74.57%. Comparing base (9455830) to head (fbe07e3).
Report is 1384 commits behind head on master.

Files with missing lines Patch % Lines
pymatgen/io/vasp/inputs.py 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3227   +/-   ##
=======================================
  Coverage   74.57%   74.57%           
=======================================
  Files         230      230           
  Lines       69493    69493           
  Branches    16166    16166           
=======================================
+ Hits        51823    51824    +1     
+ Misses      14596    14595    -1     
  Partials     3074     3074           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@janosh janosh merged commit 24f1f3c into master Aug 6, 2023
@janosh janosh deleted the refactor-test-files-dir branch August 6, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues with or changes to the pymatgen test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants