Fix undiscovered tests #3369
Merged
Fix undiscovered tests #3369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metries update tests/symmetry/test_site_symmetries.py to use json.gz files
typeidx_from_symbol snake_case to type_idx_from_symbol
janosh
added
tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The breaking part of this PR is f09769b which probably sees little use, hence no deprecation period. Can always revert if that turns out to be wrong.
696008f replace _parse_string with str.strip in PotcarSingle.parse_functions
328ae47 use keyword args to dict.update()
e9c7bee fix ruff
66304bc convert
(point_ops|shared_ops).pkltojson.gzintests/files/site_symmetries(better to avoid pickle in tests, JSON less brittle)f09769b breaking: ETSF_Reader PascalCase to EtsfReader
cfdb96f fix TestNEBAnalysis.runTest renamed test_run so pytest discovers and actually runs it
1da4729 snake_case test method names
b09647f delete get_path helper in test_surface_analysis.py
61ec39f fix doc string indent
14d32fc no need for os.path.join in tests