Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update incar_parameters.json to allow ISIF=8 #3381

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update incar_parameters.json to allow ISIF=8 #3381

merged 3 commits into from
Oct 6, 2023

Conversation

matthewkuner
Copy link
Contributor

@matthewkuner matthewkuner commented Oct 6, 2023 •
edited
Loading

simple change to include new ISIF=8 tag in list of valid tags

janosh
janosh approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewkuner. 👍

@janosh janosh enabled auto-merge (squash) October 6, 2023 22:55
@janosh janosh added tests Issues with or changes to the pymatgen test suite io Input/output functionality vasp Vienna Ab initio Simulation Package labels Oct 6, 2023
@janosh janosh changed the title Update incar_parameters.json to include new ISIF=8 tag Update incar_parameters.json to allow ISIF=8 Oct 6, 2023
@janosh janosh merged commit 8d9f6a7 into materialsproject:master Oct 6, 2023
22 checks passed
@matthewkuner matthewkuner deleted the patch-1 branch October 12, 2023 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janosh janosh janosh approved these changes

Assignees
No one assigned
Labels
io Input/output functionality tests Issues with or changes to the pymatgen test suite vasp Vienna Ab initio Simulation Package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewkuner @janosh