Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce zval to be an integer to avoid improper syntax in .cri file #3502

Merged
merged 4 commits into from
Jan 8, 2024
Merged

Enforce zval to be an integer to avoid improper syntax in .cri file #3502

merged 4 commits into from
Jan 8, 2024

Conversation

wladerer
Copy link
Contributor

@wladerer wladerer commented Dec 6, 2023 •
edited by janosh
Loading

Closes #3501.

Formatting for zval in Critic2Caller.from_path() method wrote zval as a float rather than an int, causing failure when running .cri file.

@janosh
Copy link
Member

janosh commented Dec 6, 2023

Thanks a lot! We need a test for this fix.

@janosh janosh added needs testing PRs that are not ready to merge due to lacking tests fix Bug fix PRs cli Command line interface labels Dec 6, 2023
@janosh janosh force-pushed the master branch 2 times, most recently from 3c23114 to 36e289c Compare December 19, 2023 02:10
@janosh janosh removed the needs testing PRs that are not ready to merge due to lacking tests label Jan 8, 2024
@janosh janosh enabled auto-merge (squash) January 8, 2024 09:16
@janosh janosh changed the title Enforce zval to be an integer to avoid improper syntax in .cri file … Enforce zval to be an integer to avoid improper syntax in .cri file Jan 8, 2024
@janosh janosh merged commit db45f4b into materialsproject:master Jan 8, 2024
22 checks passed
DanielYang59 pushed a commit to DanielYang59/pymatgen that referenced this pull request Jan 10, 2024
@wladerer @janosh @DanielYang59
Enforce zval to be an integer to avoid improper syntax in .cri file … (
ee04c60 
materialsproject#3502)

* Enforce zval to be an integer to avoid improper syntax in .cri file materialsproject#3501

* test with chgcar and zpsp to ensure zval is formatted as int

---------

Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli Command line interface fix Bug fix PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enforce zval to be an integer to avoid improper syntax in .cri file
2 participants
@wladerer @janosh