-
Notifications
You must be signed in to change notification settings - Fork 865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pymatgen.io.pwmat
module
#3512
Conversation
Thanks a lot! This is much appreciated! 👍 We also need extensive tests for these three new features. |
3c23114
to
36e289c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed a bunch of method names and dict keys to use snake_case. Let me know if you're ok with that. there's one more test missing for the new Structure
pwmat
IO format. otherwise this is ready to go.
Signed-off-by: LiuHanyu <41718895+lhycms@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now. Thanks a lot @lhycms for this impressive contribution! 👍
Thank you for your guidance and assistance. You are really nice😄. @janosh |
Summary
PWmat is a GPU-accelerated first-principles calculation software developed under the leadership of Professor Lin-wang Wang. I am currently utilizing it for my research project, and in the course of this work, I have written some scripts. I hope to submit them to pymatgen to assist more people in conveniently handling data in the PWmat format. This submission includes only structure file and trajectory file, and I plan to continue developing code for other input and output files in subsequent submissions.
Major changes:
pymatgen.io.pwmat.inputs.AtomConfig
which is input/output structure file, work as POCAR in vasp.pymatgen.io.pwmat.outputs.Movement
which is trajectory file generated when running MD.Todos
In the future, I will contribute code processing other input and output files for PWmat.