Improve PhononBandStructure.has_imaginary_gamma_freq() by checking for negative freqs at all q-points close to Gamma
#3530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…encies at all q-points close to the gamma point, not just the gamma point itself since dispersion curves usually below tol at gamma exactly but fall below tol very close to gamma
janosh
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6087d5d PhononDos.get_last_peak reduce threshold value from 10% to 5%
8649e79 PhononBandStructure add max_freq() equivalent to min_freq() method
0dd3527 i->idx
d92f0e7 test_bandstructure.py add new test cases for (min|max)_freq
f77779c refactor symbol mapping in ExcitingInput and PhononBandStructure
dddd81e add get_gamma_point() method to PhononBandStructure
d16e6ef add test_get_gamma_point
878ef99 big improvement to has_imaginary_gamma_freq: check for negative frequencies at all q-points close to the gamma point, not just the gamma point itself
1416791 fix test_has_imaginary_freq in test_bandstructure.py
ac38d65 PhononBandStructure add width() method
2b70e03 add test_width for PhononBandStructure