Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return self from Structure methods replace, substitute, remove_species, remove_sites #3706

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Return self from Structure methods replace, substitute, remove_species, remove_sites #3706

merged 5 commits into from
Mar 25, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Mar 25, 2024

allows chaining these methods which returned None before. updated tests to assert returned is self and added a new test for Structure.replace() which was missing coverage

@janosh janosh added api Application programming interface ux User experience core Pymatgen core labels Mar 25, 2024
@janosh janosh enabled auto-merge (squash) March 25, 2024 07:07
@janosh janosh merged commit 05d3f9f into master Mar 25, 2024
22 checks passed
@janosh janosh deleted the ret-self-struct-replace-substitute-remove branch March 25, 2024 07:18
@DanielYang59 DanielYang59 mentioned this pull request Mar 25, 2024
Merged
@janosh janosh added the types Type all the things label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep shyuep is a code owner

@mkhorton mkhorton Awaiting requested review from mkhorton mkhorton is a code owner

Assignees
No one assigned
Labels
api Application programming interface core Pymatgen core types Type all the things ux User experience
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosh