Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas.read_csv: replace deprecated delim_whitespace=True with sep="\s+" #3846

Merged
merged 3 commits into from
May 28, 2024

Conversation

ab5424
Copy link
Contributor

@ab5424 ab5424 commented May 28, 2024

Summary

Major changes:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ab5424!

@janosh janosh added deprecation Code deprecations ux User experience lammps Pymatgen LAMMPS interface labels May 28, 2024
@janosh janosh changed the title Replace deprecated delim_whitespace=True with sep="\s+" pandas.read_csv: replace deprecated delim_whitespace=True with sep="\s+" May 28, 2024
@janosh janosh enabled auto-merge (squash) May 28, 2024 21:03
@janosh janosh merged commit d2237a8 into materialsproject:master May 28, 2024
23 checks passed
@ab5424 ab5424 deleted the delim_whitespace branch May 29, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Code deprecations lammps Pymatgen LAMMPS interface ux User experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants