Prevent unit test of boltztrap2 from modifying files in place
#4095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielYang59
force-pushed
the
bt2-ci-not-gen-files
branch
from
8cf95ad
to
ff90552
Compare
DanielYang59
changed the title
boltztrap2 from generating files in placeboltztrap2 from modifying files in place
DanielYang59
force-pushed
the
bt2-ci-not-gen-files
branch
from
f303067
to
fd53bc7
Compare
Signed-off-by: Shyue Ping Ong <shyuep@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
boltztrap2from modifying files in place, to close [CI] Unit test ofboltztrap2generate files inplace #4040setUpmethodCaution
[NEED CONFIRM] replace very general
BoltztrapErrorwith more semantic exception type, cec569f