Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #5

Merged
merged 84 commits into from
Mar 5, 2020
Merged

Refactor #5

merged 84 commits into from
Mar 5, 2020

Conversation

chc273
Copy link
Contributor

@chc273 chc273 commented Mar 4, 2020

This is an extensive revision/rerwite compared to the master branch. We should use this as a starting point. Major revision points are the follows.

  1. Removed many dated codes, subpackages inherited from veidt.
  2. Incorporated a newer version of machine learning potentials from mlearn. @YunxingZuo
  3. Redone the base classes for describers and models.
  4. In the new implementations, some models/kernels/describers are not necessary, and are hence deleted.

@chc273 chc273 requested a review from shyuep March 4, 2020 21:36
@chc273 chc273 self-assigned this Mar 4, 2020
@chc273 chc273 requested a review from YunxingZuo March 4, 2020 21:36
@chc273
Copy link
Contributor Author

chc273 commented Mar 5, 2020

Merging it for now.

@chc273 chc273 merged commit 181deb6 into master Mar 5, 2020
@chc273 chc273 deleted the refactor branch March 5, 2020 17:57
@xinglong-zhang xinglong-zhang mentioned this pull request May 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shyuep shyuep Awaiting requested review from shyuep

@YunxingZuo YunxingZuo Awaiting requested review from YunxingZuo

Assignees

@YunxingZuo YunxingZuo

@chc273 chc273

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chc273 @YunxingZuo