Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for data.length redundant? #17

Closed
Adgek opened this issue Dec 27, 2015 · 2 comments
Closed

Check for data.length redundant? #17

Adgek opened this issue Dec 27, 2015 · 2 comments
Labels

Comments

@Adgek
Copy link

Adgek commented Dec 27, 2015

In my code i am often trying to load a table that might have no data in it. I was hoping to get the noResults message of "No matching records" instead of my js returning. By commenting out this section here in v-client-table.js create method
// if (!this.data.length) {
// console.error("v-client-table: the data array must have at least one row object.");
// return;
// }
It seems to have the wanted effect of telling me that i have no matching records. Leads me to believe that you already handle this issue. Might be totally mistaken here though.

@matfish2
Copy link
Owner

You are right. I will fix it soon. Thank you.

@Adgek
Copy link
Author

Adgek commented Dec 27, 2015

Awesome thanks :)

matfish2 added a commit that referenced this issue Dec 27, 2015
matfish2 added a commit that referenced this issue Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants