Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

null values in data #18

Closed
nuklehed opened this issue Feb 26, 2016 · 2 comments
Closed

null values in data #18

nuklehed opened this issue Feb 26, 2016 · 2 comments
Assignees
Labels

Comments

@nuklehed
Copy link

When my data set has null values I am getting an isValid exception. I've traced it back to the is-valid-moment-object helper:

module.exports = function(val) { return typeof val.isValid=='function' && val.isValid(); }

My hack was to add (null!==val) to the return:

return (null!==val) && typeof val.isValid=='function' && val.isValid();

Use the jsfiddle to recreate the issue. Simply change one of tableData's property values to null and run:jsfiddle

Could be a better way to address this, but without change how my app returns data, this was the simplest method. Anxious to hear any feedback.

Thanks!

matfish2 added a commit that referenced this issue Feb 26, 2016
@matfish2 matfish2 added the bug label Feb 26, 2016
@matfish2
Copy link
Owner

Thanks. Fixed it.

@matfish2 matfish2 self-assigned this Feb 26, 2016
@nuklehed
Copy link
Author

Awesome tool. Glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants