Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

naming in ereal.v #597

Closed
affeldt-aist opened this issue Mar 15, 2022 · 3 comments · Fixed by #615
Closed

naming in ereal.v #597

affeldt-aist opened this issue Mar 15, 2022 · 3 comments · Fixed by #615

Comments

@affeldt-aist
Copy link
Member

analysis/theories/ereal.v

Lines 769 to 772 in 8b15a95

Lemma addooe x : x != -oo -> +oo + x = +oo.
Proof. by case: x. Qed.
Lemma addeoo x : x != -oo -> x + +oo = +oo.

wouldn't addpinftye and addepinfty bet better names?
@proux01
Copy link
Collaborator

proux01 commented Mar 15, 2022

Maybe add_pinfty_e and adde_pinfty but that's much longer. I don't know what's best.

affeldt-aist added a commit that referenced this issue Mar 28, 2022
@affeldt-aist
fixes #597
e1119fe
@affeldt-aist affeldt-aist mentioned this issue Mar 28, 2022
Merged
2 tasks
@affeldt-aist
Copy link
Member Author

I am not sure either. Are we sure we want to sick to infty for "infinity"? oo is much shorter...

@proux01
Copy link
Collaborator

proux01 commented Mar 28, 2022

I also like the conciseness of oo. I added that point to the topics for next meeting.

affeldt-aist added a commit that referenced this issue Mar 31, 2022
@affeldt-aist
fixes #597
e757b78
CohenCyril pushed a commit that referenced this issue Apr 5, 2022
@affeldt-aist
fixes #597 (infty -> y) (#615)
3ea015d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #597 (infty -> y) math-comp/analysis
2 participants
@proux01 @affeldt-aist