Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to https://github.com/math-comp/math-comp/pull/1052 #1029

Closed
wants to merge 1 commit into from

Conversation

proux01
Copy link
Collaborator

@proux01 proux01 commented Sep 23, 2023

Adapt to math-comp/math-comp#1052

Backport of #1028

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Compatibility with MathComp 2.0
  • I added the label TODO: HB port to make sure someone ports this PR to
    the hierarchy-builder branch or I already opened an issue or PR (please cross reference).
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@proux01 proux01 force-pushed the mc_1052 branch 2 times, most recently from 8c1e79c to 8896294 Compare September 23, 2023 14:57
@proux01
Copy link
Collaborator Author

proux01 commented Dec 21, 2023

Rebased, let's see what CI looks like.

@affeldt-aist affeldt-aist marked this pull request as draft December 21, 2023 14:06
@affeldt-aist
Copy link
Member

We do not know if it is still needed, so we convert it to draft and wait.

@proux01
Copy link
Collaborator Author

proux01 commented Dec 21, 2023

Apparently not really needed (otheriwse some CI somewehre would hve complained)

@proux01 proux01 deleted the mc_1052 branch December 21, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants