-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ax5 added to PseudoMetric.mixin_of #305
Conversation
affeldt-aist
commented
Dec 11, 2020
•
edited
Loading
edited
- does not compile
- and there is an admit
- does not compile
3764994
to
9a59091
Compare
|
||
Lemma fct_open_ball x e : open (fct_ball x e). | ||
Proof. | ||
Admitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure to understand why fct_open_ball
should be true. Isn't there some continuity hypothesis at stake ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I don't even think continuity is enough. There is no reason for this to be true.
It seems we have to backtrack on our decision to add ax5
and introduce open_ball x e = (ball x e)°
instead... WDYT?
- structure of topologicalType for zmodType to type-check pseudoMetric_of_normedDomain
by adding a topological structure to zmodType, I am afraid I start doing things that look like PR #205 |
One should not do that, you are adding a trivial topology where everything is open, indeed you defined singletons to be open, hence any set, as an arbitrary union of singletons is automatically open... Moreover, if you were to add the discrete topology instead, it would be incompatible with any other topology that we use... If one really need discrete topologies, they need to introduce an alias |
well, this was really to keep going and uncover more problems, if we are to have a topologicalType as a parameter of the pseudometric mixin then the end of the file needs to be changed for we cannot used |
I'm not sure I understand... |
I think that |
I do not understand why you say that, moreover |
It was to type check the |
Then all you need is the topology of a normedZmodType structure, and it must and should not be canonical, but local, since we are defining a factory on this line. |
I'll go back to it asap once ax5 is fixed as you suggested above. |
We gave up extending the interface of pseudometric spaces. This PR is scheduled to be closed as it is. A related discussion is going on in PR #283 . |