Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ax5 added to PseudoMetric.mixin_of #305

Closed
wants to merge 2 commits into from
Closed

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Dec 11, 2020

  • does not compile
  • and there is an admit

@affeldt-aist affeldt-aist marked this pull request as draft December 11, 2020 04:42

Lemma fct_open_ball x e : open (fct_ball x e).
Proof.
Admitted.
Copy link
Collaborator

@mkerjean mkerjean Dec 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to understand why fct_open_ball should be true. Isn't there some continuity hypothesis at stake ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't even think continuity is enough. There is no reason for this to be true.
It seems we have to backtrack on our decision to add ax5 and introduce open_ball x e = (ball x e)° instead... WDYT?

- structure of topologicalType for zmodType to type-check
  pseudoMetric_of_normedDomain
@affeldt-aist
Copy link
Member Author

by adding a topological structure to zmodType, I am afraid I start doing things that look like PR #205

@CohenCyril
Copy link
Member

by adding a topological structure to zmodType, I am afraid I start doing things that look like PR #205

One should not do that, you are adding a trivial topology where everything is open, indeed you defined singletons to be open, hence any set, as an arbitrary union of singletons is automatically open...

Moreover, if you were to add the discrete topology instead, it would be incompatible with any other topology that we use... If one really need discrete topologies, they need to introduce an alias discrete T := T and have canonicals on discrete instead...

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Dec 11, 2020

well, this was really to keep going and uncover more problems, if we are to have a topologicalType as a parameter of the pseudometric mixin then the end of the file needs to be changed for we cannot used topologyOfEntourageMixin anymore, am I wrong?

@CohenCyril
Copy link
Member

well, this was really to keep going and uncover more problems, if we are to have a topologicalType as a parameter of the pseudometric mixin then the end of the file needs to be changed for we cannot used topologyOfEntourageMixin anymore, am I wrong?

I'm not sure I understand...

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Dec 11, 2020

well, this was really to keep going and uncover more problems, if we are to have a topologicalType as a parameter of the pseudometric mixin then the end of the file needs to be changed for we cannot used topologyOfEntourageMixin anymore, am I wrong?

I'm not sure I understand...

I think that normedZ zmodType needs to be given its topological structure earlier

@CohenCyril
Copy link
Member

I think that normedZ zmodType needs to be given its topological structure earlier

I do not understand why you say that, moreover zmodType should not have a canonical structure...

@affeldt-aist
Copy link
Member Author

I think that normedZ zmodType needs to be given its topological structure earlier

I do not understand why you say that, moreover zmodType should not have a canonical structure...

It was to type check the open (ball_ Num.Def.normr x e) statement at line 4364 (though now we know that we can't do with this axiom anyway).

@CohenCyril
Copy link
Member

It was to type check the open (ball_ Num.Def.normr x e) statement at line 4364 (though now we know that we can't do with this axiom anyway).

Then all you need is the topology of a normedZmodType structure, and it must and should not be canonical, but local, since we are defining a factory on this line.

@affeldt-aist
Copy link
Member Author

It was to type check the open (ball_ Num.Def.normr x e) statement at line 4364 (though now we know that we can't do with this axiom anyway).

Then all you need is the topology of a normedZmodType structure, and it must and should not be canonical, but local, since we are defining a factory on this line.

I'll go back to it asap once ax5 is fixed as you suggested above.

@affeldt-aist
Copy link
Member Author

We gave up extending the interface of pseudometric spaces. This PR is scheduled to be closed as it is. A related discussion is going on in PR #283 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants