Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boundary conditions with subspace #505

Merged
merged 3 commits into from
Feb 18, 2022

Conversation

zstone1
Copy link
Contributor

@zstone1 zstone1 commented Dec 27, 2021

Fixes #408 (except in realfun.v. We should open another ticket for that, as it's a bit more work).

This

  1. introduces a notation {within A, continuous f}, to indicate continuity on the subspace. This is hacky, and needs fixing (see {in A, continuous f} has bad boundary conditions #408) for further discussion
  2. A bunch of additional lemmas about subspaces, their continuity, and closed sets
  3. Fixes boundary conditions for
    a. continuous image of connected is connected
    b. continuous image of compact is compact
    c. EVT, and it's friends, including Rolle's theorem, and MVT.
    d. interval_connectedP, and IVT, including a dramatic simplification of that proof.

Note that I use some scaffolding code for realfun.v to change the {in I, continuous f} to {within I, continuous f}. It's not much, but rewriting the whole thing is a lot of lines changed, and requires a couple tougher lemmas (such as letting us convert between fmap f (nbhs {subspace A} x) and nbhs {subspace (f@A)} f awhen f is a homeomorphism). Specifically, this comes up insegment_can_ge, where the subspace swaps from [a,b]to[-b, -a]`.

I think the scaffolding in realfun.v is fine, and can be handled in a separate diff. The notation should be fixed, at least.

@zstone1
Copy link
Contributor Author

zstone1 commented Jan 20, 2022

Merges are all resolved here. Build is broken, but that seems to be affecting more than just this change. Can we get this into the next release?

theories/derive.v Outdated Show resolved Hide resolved
theories/derive.v Outdated Show resolved Hide resolved
theories/derive.v Outdated Show resolved Hide resolved
theories/realfun.v Outdated Show resolved Hide resolved
theories/topology.v Outdated Show resolved Hide resolved
theories/topology.v Outdated Show resolved Hide resolved
theories/derive.v Outdated Show resolved Hide resolved
zstone1 and others added 3 commits February 17, 2022 17:40
cleanup topology

fixing notations

minor cleanups

fixing build

more merge fixes

cleaning up names

fix build

renaming openC and closedC

updating changelog

updating changelog
- tidy up scripts
- remove trailing spaces
- complete changelog
@affeldt-aist affeldt-aist self-requested a review February 18, 2022 03:36
Copy link
Member

@affeldt-aist affeldt-aist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I proof-read the changes and only found minor improvements. It is ok to merge with me.

@affeldt-aist affeldt-aist added this to the 0.3.14 milestone Feb 18, 2022
@zstone1 zstone1 merged commit 2740d97 into math-comp:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

{in A, continuous f} has bad boundary conditions
3 participants