-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix boundary conditions with subspace #505
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zstone1
force-pushed
the
fix_boundaries
branch
from
January 20, 2022 13:18
a976d92
to
d055a35
Compare
Merges are all resolved here. Build is broken, but that seems to be affecting more than just this change. Can we get this into the next release? |
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
CohenCyril
reviewed
Jan 20, 2022
zstone1
force-pushed
the
fix_boundaries
branch
from
January 21, 2022 17:56
3c87e99
to
55d12de
Compare
zstone1
force-pushed
the
fix_boundaries
branch
from
February 17, 2022 22:40
55d12de
to
4dad600
Compare
cleanup topology fixing notations minor cleanups fixing build more merge fixes cleaning up names fix build renaming openC and closedC updating changelog updating changelog
- tidy up scripts - remove trailing spaces - complete changelog
affeldt-aist
approved these changes
Feb 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I proof-read the changes and only found minor improvements. It is ok to merge with me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408 (except in realfun.v. We should open another ticket for that, as it's a bit more work).
This
{within A, continuous f}
, to indicate continuity on the subspace. This is hacky, and needs fixing (see {in A, continuous f} has bad boundary conditions #408) for further discussiona. continuous image of connected is connected
b. continuous image of compact is compact
c. EVT, and it's friends, including Rolle's theorem, and MVT.
d. interval_connectedP, and IVT, including a dramatic simplification of that proof.
Note that I use some scaffolding code for realfun.v to change the
{in I, continuous f}
to{within I, continuous f}
. It's not much, but rewriting the whole thing is a lot of lines changed, and requires a couple tougher lemmas (such as letting us convert betweenfmap f (nbhs {subspace A} x)
andnbhs {subspace (f
@A)} f awhen f is a homeomorphism). Specifically, this comes up in
segment_can_ge, where the subspace swaps from
[a,b]to
[-b, -a]`.I think the scaffolding in realfun.v is fine, and can be handled in a separate diff. The notation should be fixed, at least.