Adapt to coq/coq#16798 (cast in pattern is an error by default) #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A pattern `x : y` is equivalent to just `x`. Some of the casts were bogus and so were removed. Other casts come from notations (from constructive_ereals around line 260), for these the warning was ignored as it seems ignoring them was not a problem.
|
(if you think making this warning error by default this is the right time to say so, the right place is the coq side PR) |
affeldt-aist
approved these changes
Nov 25, 2022
|
I'm not so happy about them... |
|
Do you mean that you are unhappy with the fact that they are ineffective? |
|
No I'm unhappy about the verbosity |
SkySkimmer
commented
Dec 8, 2022
| @@ -2427,7 +2427,11 @@ Arguments lee_sum_nneg_natr {R}. | |||
| Arguments lee_sum_npos_natr {R}. | |||
| Arguments lee_sum_nneg_natl {R}. | |||
| Arguments lee_sum_npos_natl {R}. | |||
|
|
|||
| (* <=%E contains casts but we don't mind that they are ignored when matching for this hint *) | |||
| Set Warnings "-cast-in-pattern". | |||
| #[global] Hint Extern 0 (is_true (0 <= `| _ |)%E) => solve [apply: abse_ge0] : core. | |||
There was a problem hiding this comment.
An alternative to unsetting warnings would be to avoid the notation, ie here we would do
Suggested change
| #[global] Hint Extern 0 (is_true (0 <= `| _ |)%E) => solve [apply: abse_ge0] : core. | |
| #[global] Hint Extern 0 (is_true (lee 0 `| _ |)%E) => solve [apply: abse_ge0] : core. |
(not sure if we need %E for the `| _ |)
also with coq/coq#16902 we could do
Suggested change
| #[global] Hint Extern 0 (is_true (0 <= `| _ |)%E) => solve [apply: abse_ge0] : core. | |
| #[global, warnings="-cast-in-pattern"] Hint Extern 0 (is_true (0 <= `| _ |)%E) => solve [apply: abse_ge0] : core. |
(no Unset Warnings) which is less verbose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pattern
x : yis equivalent to justx.Some of the casts were bogus and so were removed.
Other casts come from notations (from constructive_ereals around line 260), for these the warning was ignored as it seems ignoring them was not a problem.