rename and doc finSubCover #832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Quote from issue #658:
Indeed. |
|
Or maybe we can try to use And then the |
affeldt-aist
force-pushed
the
fixes_658
branch
from
3a74ea5
to
854b088
Compare
|
@zstone1 do you think that this is a reasonable change? |
zstone1
approved these changes
Feb 3, 2023
- use cover in finSubCover - use [set: ] instead of @Sett - use shortcut notation for set comprehension
affeldt-aist
force-pushed
the
fixes_658
branch
from
854b088
to
6eda319
Compare
|
@t6s do you think this PR fixes your issue? |
t6s
approved these changes
Feb 6, 2023
hoheinzollern
pushed a commit
to hoheinzollern/analysis
that referenced
this pull request
Mar 9, 2023
- use cover in finSubCover - use [set: ] instead of @Sett - use shortcut notation for set comprehension
proux01
pushed a commit
that referenced
this pull request
Mar 24, 2023
- use cover in finSubCover - use [set: ] instead of @Sett - use shortcut notation for set comprehension
proux01
pushed a commit
that referenced
this pull request
Mar 24, 2023
- use cover in finSubCover - use [set: ] instead of @Sett - use shortcut notation for set comprehension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #658
I added a documentation entry.
Since the naming was questioned, I propose a new one that essentially gets rid of camlCase
which is more commonly used for mixins and structures in MathComp.
I haven't changed the definition as suggested by the issue.
Things done/to do
CHANGELOG_UNRELEASED.mdAutomatic note to reviewers
Read this Checklist and put a milestone if possible.