Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify status of lemmas in altreals #833

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

affeldt-aist
Copy link
Member

Motivation for this change

It has been brought to our attention that the status of some lemmas
in altreals should be clarified. Since the lemmas in question should at
some point be subsumed by the more general theory of measure in
theories, this PR proposes to use deprecated flags for this purpose.

@CohenCyril @strub

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
    - [ ] added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist added this to the 0.6.1 milestone Feb 2, 2023
Copy link
Collaborator

@proux01 proux01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating seems a good short term solution

@affeldt-aist affeldt-aist marked this pull request as draft February 6, 2023 13:53
@affeldt-aist affeldt-aist modified the milestones: 0.6.1, 0.6.2 Feb 11, 2023
@affeldt-aist affeldt-aist added the documentation 📝 This issue/PR is about documentation of the library / repository label Mar 15, 2023
Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes let's deprecated lemmas with no proof

@CohenCyril CohenCyril added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Mar 27, 2023
@affeldt-aist affeldt-aist marked this pull request as ready for review April 21, 2023 05:27
@affeldt-aist affeldt-aist merged commit 7608ef0 into math-comp:master Apr 21, 2023
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Apr 29, 2023
@affeldt-aist affeldt-aist deleted the deprecated_20230201 branch August 6, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation 📝 This issue/PR is about documentation of the library / repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants