Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Concepts page for data types #14

Closed
kgodey opened this issue Nov 26, 2021 · 2 comments
Closed

Create Concepts page for data types #14

kgodey opened this issue Nov 26, 2021 · 2 comments
Assignees
Labels
restricted: maintainers Only maintainers can resolve this issue status: done This issue or discussion has been resolved type: enhancement New feature or request work: documentation Improvements or additions to documentation

Comments

@kgodey
Copy link
Contributor

kgodey commented Nov 26, 2021

We need to clearly define what a data type is and what a Mathesar type is.

Related discussions:

@kgodey kgodey added restricted: maintainers Only maintainers can resolve this issue status: ready Ready for implementation work: documentation Improvements or additions to documentation labels Nov 26, 2021
@kgodey kgodey self-assigned this Nov 26, 2021
@kgodey kgodey added the type: enhancement New feature or request label Nov 26, 2021
@mathemancer
Copy link
Contributor

Passing comment:

We have the following type concepts so far:

  • proper PostgreSQL types that come out-of-the-box
  • Mathesar types that are implemented as PostgreSQL DOMAINs. This means that they're just basic PostgreSQL types, plus a check condition that ensures they fit some form. In the case of those currently implemented, they also come with DB-layer convenience functions to pluck out different parts (e.g., the local-part of an email) of the entry.
  • Mathesar types that are implemented as display options of a different type (e.g., percents). It's debatable whether these are proper types, since they don't really enforce anything or include any functionality beyond the underlying types.
  • Composite types (we don't have these yet, but we've noted the concept in other places). These are types composed of come combination of other primitive types.

Should all of the above look like "types" to the user? If so, should the difference between a primitive type and DOMAIN type be exposed somehow? (I've passed over the "function / generated" type above, since we already discussed that elsewhere).

@kgodey kgodey added this to the [07] Initial Data Types milestone Dec 17, 2021
@kgodey kgodey added status: started In progress and removed status: ready Ready for implementation labels Jan 5, 2022
@kgodey
Copy link
Contributor Author

kgodey commented Jan 6, 2022

This is done, discussion with the details: mathesar-foundation/mathesar#959

@kgodey kgodey closed this as completed Jan 6, 2022
@kgodey kgodey added status: done This issue or discussion has been resolved and removed status: started In progress labels Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
restricted: maintainers Only maintainers can resolve this issue status: done This issue or discussion has been resolved type: enhancement New feature or request work: documentation Improvements or additions to documentation
Projects
No open projects
Development

No branches or pull requests

2 participants