Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI] Error message gets displayed even when the table name is set to its prior name #1161

Closed
ManishShah120 opened this issue Mar 11, 2022 · 2 comments · Fixed by #1163
Closed

[UI] Error message gets displayed even when the table name is set to its prior name #1161

ManishShah120 opened this issue Mar 11, 2022 · 2 comments · Fixed by #1163
Assignees
@sariyahsintayehu
Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Milestone
[06.1] 2022-03 im...

Comments

@ManishShah120
Copy link
Contributor

Description

When we try to rename a table, but later undo the field with the name of the table as before the error message is still displayed, which should not be expected.

Expected behavior

The error message should not be displayed as soon as the table name is set to its prior name.

To Reproduce

1. Create an empty table.
2. Try to rename the table name.
3. Then again undo the changes or keep the name of the table as before.

Environment

  • OS: (eg. macOS 10.14.6; Fedora 32)
  • Browser: (eg. Safari; Firefox; Brave; Chrome)
  • Browser Version: (eg. 13; 73)
  • Other info:

Additional context

Here's a GIF/Video of it

Clipped.mp4
@ManishShah120 ManishShah120 added status: triage type: bug Something isn't working labels Mar 11, 2022
@kgodey kgodey added good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this ready Ready for implementation work: frontend Related to frontend code in the mathesar_ui directory and removed status: triage labels Mar 11, 2022
@kgodey kgodey added this to the [06.1] 2022-03 improvements milestone Mar 11, 2022
@kgodey
Copy link
Contributor

kgodey commented Mar 11, 2022

Thanks for reporting, @ManishShah120.

@sariyahsintayehu sariyahsintayehu mentioned this issue Mar 12, 2022
Merged
7 tasks
@kgodey kgodey added status: started and removed ready Ready for implementation labels Mar 12, 2022
@sariyahsintayehu
Copy link

Hello, there. I am working on a solution to this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sariyahsintayehu sariyahsintayehu

Labels
good first issue Everything in "Help wanted", PLUS being relatively easy and straightforward to implement. help wanted Community contributors can implement this type: bug Something isn't working work: frontend Related to frontend code in the mathesar_ui directory
Projects
No open projects
[NO LONGER USED] Mathesar work tracker
Archived in project
Milestone
[06.1] 2022-03 improvements
Development

Successfully merging a pull request may close this issue.

FIX: tables can be renamed to their current name sariyahsintayehu/mathesar
3 participants
@kgodey @sariyahsintayehu @ManishShah120