Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max column name size (during CSV import) further #2725

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

mathemancer
Copy link
Contributor

@mathemancer mathemancer commented Mar 20, 2023

Fixes #2714

This reduces the max length for an identifier to 48 bytes.

Technical details

We should be able to support up to 63 bytes (as we had set previously), since this is what PostgreSQL supports. However, that's not working, and it's not worth figuring out which part of a machine we're going to rework over the next month is mangling the identifiers.

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the develop branch of the repository
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@mathemancer mathemancer added the pr-status: review A PR awaiting review label Mar 20, 2023
@mathemancer mathemancer added this to the v0.1.1 milestone Mar 20, 2023
@mathemancer mathemancer marked this pull request as draft March 20, 2023 13:59
@mathemancer
Copy link
Contributor Author

Converting to draft; We've decided to try harder to figure out what the actual underlying issue is.

@mathemancer mathemancer modified the milestones: v0.1.1, v0.1.2 Mar 20, 2023
@pavish pavish changed the base branch from 0.1.1 to develop March 20, 2023 14:29
@dmos62 dmos62 assigned dmos62 and unassigned silentninja Mar 28, 2023
@dmos62
Copy link
Contributor

dmos62 commented Mar 28, 2023

Taking this over after checking with @silentninja.

@dmos62 dmos62 added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Mar 28, 2023
@dmos62 dmos62 changed the title Reduce max column name length further Reduce max column name size (during CSV import) further Mar 28, 2023
@dmos62 dmos62 marked this pull request as ready for review March 28, 2023 15:23
@dmos62 dmos62 added pr-status: review A PR awaiting review work: backend Related to Python, Django, and simple SQL and removed pr-status: revision A PR awaiting follow-up work from its author after review labels Mar 28, 2023
db/identifiers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@silentninja silentninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @dmos62, other than the previously requested changes to the identifier_size_limit I don't have any other concerns. Please merge the PR after making the requested change

@rajatvijay rajatvijay added pr-status: revision A PR awaiting follow-up work from its author after review and removed pr-status: review A PR awaiting review labels Apr 13, 2023
@dmos62 dmos62 enabled auto-merge April 14, 2023 12:19
@dmos62 dmos62 added this pull request to the merge queue Apr 14, 2023
Merged via the queue into develop with commit 8d53d6f Apr 14, 2023
@dmos62 dmos62 deleted the longnamecsv_bug branch April 14, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-status: revision A PR awaiting follow-up work from its author after review work: backend Related to Python, Django, and simple SQL
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Internal server error when importing CSVs with long names
4 participants