-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce max column name size (during CSV import) further #2725
Conversation
Converting to draft; We've decided to try harder to figure out what the actual underlying issue is. |
Taking this over after checking with @silentninja. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @dmos62, other than the previously requested changes to the identifier_size_limit
I don't have any other concerns. Please merge the PR after making the requested change
Fixes #2714
This reduces the max length for an identifier to 48 bytes.
Technical details
We should be able to support up to 63 bytes (as we had set previously), since this is what PostgreSQL supports. However, that's not working, and it's not worth figuring out which part of a machine we're going to rework over the next month is mangling the identifiers.
Screenshots
Checklist
Update index.md
).develop
branch of the repositoryvisible errors.
Developer Certificate of Origin
Developer Certificate of Origin