Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemVer bumping is not working for Major version and pull requests #52

Closed
bhojjoshi opened this issue Jan 6, 2021 · 2 comments
Closed

Comments

@bhojjoshi
Copy link

Getting below error for pull request:
Error: 1.0.9-refs/pull/2/merge.0 is not a valid semver

For the major version upgrade, providing the "BREAKING CHANGE: message" is not bumping the major version rather bumping the patch version.

@mathieudutour
Copy link
Owner

Getting below error for pull request:

Duplicates of #51

For the major version upgrade, providing the "BREAKING CHANGE: message" is not bumping the major version rather bumping the patch version.

The "BREAKING CHANGE" needs to be in the commit's body - not its title.

@koiralakiran1
Copy link
Contributor

koiralakiran1 commented Jan 6, 2021

For the major version upgrade, providing the "BREAKING CHANGE: message" is not bumping the major version rather bumping the patch version.

The "BREAKING CHANGE" needs to be in the commit's body - not its title.

@mathieudutour Can you please elaborate how to trigger other version bumps (except patch i.e. default) with an example commit message?
My commit message looks like: (git commit -m "Test commit" -m "Minor")
image

And my custom_release_rules is:
image

But it only bumps the patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants