Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3] LiteAdaptor's elementsByClass() fails to return any elements. #2278

Closed
dpvc opened this issue Dec 31, 2019 · 0 comments
Closed

[v3] LiteAdaptor's elementsByClass() fails to return any elements. #2278

dpvc opened this issue Dec 31, 2019 · 0 comments
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3.0
Milestone
MathJax v3.0.1

Comments

@dpvc
Copy link
Member

dpvc commented Dec 31, 2019 •
edited

The LiteAdaptor's elementsByClass() throws an error about the class.find() argument. In particular

https://github.com/mathjax/MathJax-src/blob/28233c6d2d3ffea10cd223c11903e4e97079a8ce/ts/adaptors/liteAdaptor.ts#L197-L198

should use classes.includes(name) rather than classes.find(name), and tags.push(n) rather than tags = [].
dpvc added a commit to mathjax/MathJax-src that referenced this issue Dec 31, 2019
@dpvc
Fix LiteAdaptor's elementsByClass() function, and getElements(). Reso…
0109be6 
…lves issue mathjax/MathJax#2278.
@dpvc dpvc mentioned this issue Dec 31, 2019
Merged
@dpvc dpvc added Accepted Issue has been reproduced by MathJax team Ready for Review Test Needed labels Dec 31, 2019
@dpvc dpvc added this to the MathJax v3.0.1 milestone Dec 31, 2019
dpvc added a commit to mathjax/MathJax-src that referenced this issue Jan 3, 2020
@dpvc
Merge pull request #416 from mathjax/issue2278
3cb0425 
Fix LiteAdaptor's search for elements by class. mathjax/MathJax#2278.
@dpvc dpvc added Merged Merged into develop branch and removed Ready for Review labels Jan 3, 2020
@dpvc dpvc added Fixed v3.0 and removed Merged Merged into develop branch labels Feb 10, 2020
@dpvc dpvc closed this as completed Feb 10, 2020
@snyk-bot snyk-bot mentioned this issue Apr 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepted Issue has been reproduced by MathJax team Fixed Test Needed v3.0
Projects
None yet
Milestone
MathJax v3.0.1
Development

No branches or pull requests
1 participant
@dpvc