add test for MathJax/MathJax#912 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if that's what you had in mind. Should I split it into two tests? |
| try { | ||
| check = ( mstyle.getAttribute('scriptlevel') === '0' && mstyle.getAttribute('displaystyle') === 'false'); | ||
| } | ||
| catch (err) {check = false}; |
There was a problem hiding this comment.
This works, but you should be able to do it without the overhead of try/catch. How about:
var check = !!(mstyle && mstyle.getAttribute('scriptlevel') === '0' && mstyle.getAttribute('displaystyle') === 'false');
|
I think one test is fine for this. If you want, you could do return [
newScriptReftestResult("Scriplevel 0",(mstyle && mstyle.getAttribute('scriptlevel') === '0')),
newScriptReftestResult("Displaystyle false",(mstyle && mstyle.getAttribute('displaystyle') === 'false'))
];which would be one test file with each part tested separately. |
| catch (err) {check = false}; | ||
| return [ | ||
| newScriptReftestResult("Check displaystyle and scriptlevel changes in toMathML() output", | ||
| check), |
There was a problem hiding this comment.
You don't want the final comma, since that will fail in IE < 9.
|
How about now? |
|
Looks good. The copyright date could be changed and scriptlevel and displaystyle shouldn't be capitalized now that they are not the beginning of the sentence, but I wouldn't worry about those. I'll merge... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.