Add Cyberpunk with network stats theme #136
Conversation
|
Thanks for submitting this updated theme! Can you also add your new theme to the
This way it will be tested by the CI 👍 |
Did it! |
|
Thanks! Did you also see my 2 comments on the theme file? |
|
@mathoudebine no, I couldn't find your comments |
res/themes/Cyberpunk-net/theme.yaml
Outdated
| USED: | ||
| SHOW: True | ||
| SHOW_UNIT: True | ||
| X: 28 |
There was a problem hiding this comment.
The used RAM text value should be moved slightly to the right, in case the value is more than 10GB:
There was a problem hiding this comment.
Thanks, that was because library/stats.py had a fixed length for the string converted. I removed that, but I'm not sure if it will impact the other themes, although I think it shouldn't be fixed anyways...
res/themes/Cyberpunk-net/theme.yaml
Outdated
| Y: 330 | ||
| FONT: jetbrains-mono/JetBrainsMono-Bold.ttf | ||
| FONT_SIZE: 23 | ||
| FONT_COLOR: 255, 255, 255 |
There was a problem hiding this comment.
I think the donwload & upload texts would look better if they use the generale-mono/GeneraleMonoA.ttf font and the FONT_COLOR: 2, 216, 243 cyan color of the theme
There was a problem hiding this comment.
Did it, thanks for reporting
|
Sorry @amiltonjr i did not validate the comments! You can see them now |
|
@mathoudebine I just updated the PR with your suggestions |
| @@ -428,7 +428,7 @@ def stats(): | |||
| if THEME_DATA['STATS']['MEMORY']['VIRTUAL']['USED'].get("SHOW", False): | |||
| virtual_used = sensors.Memory.virtual_used() | |||
|
|
|||
| virtual_used_text = f"{int(virtual_used / 1000000):>5}" | |||
| virtual_used_text = f"{int(virtual_used / 1000000)}" | |||
There was a problem hiding this comment.
The padding in the value should not be removed: it is used to avoid "screen persistence" when a short value is written after a longer one.
With the padding we are sure the longer value is erased completely, otherwise the previous unit is still displayed like in the picture.
There was a problem hiding this comment.
@mathoudebine just commited a fix, please try it again and see if it solves the problem
There was a problem hiding this comment.
I just tested your new modification, but there is still an issue with changing alignment of the virtual memory value from right to left.
It breaks other themes that are made for the value aligned to the right, like 3.5inchTheme:
I'm sorry but this modification cannot be made in the code for all themes.
I will have to think of a way to specify if the value must be left or right aligned in the theme file.
In the meantime, you can remove this modification from the PR so i can merge it here, and keep it only in your repository if you want!
|
I've merged your PR to unblock other waiting PRs but i reverted the change on the master branch for the memory value alignment as i explained on the previous comment. |
No description provided.