Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a bug for clients with realtime access #149

Merged
merged 1 commit into from Dec 6, 2022

Conversation

doluk
Copy link
Collaborator

@doluk doluk commented Dec 5, 2022

The wrong scope prevented the key creation with email and password and force the users to login with keys

The wrong scope prevented the key creation with  email and password and force the users to login with keys
@majordoobie
Copy link
Collaborator

Can you please post a snippet of code that errored because of this bug so I can see how your changes fixed it.

@majordoobie majordoobie self-assigned this Dec 6, 2022
@majordoobie majordoobie self-requested a review December 6, 2022 22:48
@doluk
Copy link
Collaborator Author

doluk commented Dec 6, 2022

The error is invoked here. It raises an key error. If you look into resp, it comes back with a message pointing to the invalid scope. I double checked it with the inspect mode of the browser. The request on the site is for realtime accounts with the modified scopes. So yeah, ...

@majordoobie majordoobie changed the base branch from master to g5_2.2.2_candidate December 6, 2022 23:27
@majordoobie
Copy link
Collaborator

Confirmed error and fix. Merging into 2.2.2 candidate

@majordoobie majordoobie merged commit 7f8d5e8 into mathsman5133:g5_2.2.2_candidate Dec 6, 2022
@majordoobie majordoobie mentioned this pull request Dec 21, 2022
@doluk doluk deleted the patch-3 branch December 27, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants