Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Listr dependency and parallelize tasks #134

Merged
merged 5 commits into from
Jan 12, 2023
Merged

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Jan 6, 2023

Description

This PR introduces some concurrency while executing the setup tasks in matic-cli wherever applicable. It also updates Listr (which is the dependency used in matic-cli for organizing and executing the network setup jobs) to Listr2 in favour of a well maintained but also a like-for-like replacement.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Copy link
Contributor

@marcello33 marcello33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once prettier/linter is fixed, LGTM

@Raneet10 Raneet10 marked this pull request as ready for review January 10, 2023 12:43
@Raneet10 Raneet10 merged commit ead34d3 into master Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants