Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generate random chain ids when bor/heimdall chain ids are not provided #140

Merged
merged 3 commits into from
Jan 30, 2023
Merged

fix: generate random chain ids when bor/heimdall chain ids are not provided #140

merged 3 commits into from
Jan 30, 2023

Conversation

Raneet10
Copy link
Member

Description

Earlier when bor/heimdall chain Ids were not provided in .env , express-cli didn't generate a random one. This PR fixes that.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

marcello33
marcello33 requested changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@marcello33 marcello33 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make it work with edge cases too (empty, null, undefined, numbers...)

@Raneet10
Copy link
Member Author

Need to make it work with edge cases too (empty, null, undefined, numbers...)

Yes it's more appropriate to do these checks in the env validator

@marcello33 marcello33 merged commit 1167a34 into master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcello33 marcello33 marcello33 approved these changes

@0xsharma 0xsharma 0xsharma approved these changes

@temaniarpit27 temaniarpit27 Awaiting requested review from temaniarpit27

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Raneet10 @0xsharma @marcello33