Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use bor_getAuthor instead of block.miner to fetch block miner #151

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Feb 8, 2023

Description

Earlier when fetching a block via getBlock returned the block producer address instead of 0x00... in the block.miner field. This change was reverted in maticnetwork/bor#631 . This led to breaking some assertions in EIP-1559 test script. This PR fixes that.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants