Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mardizzone/POS-1058: run devnets behind VPN and Bastillion #155

Merged
merged 8 commits into from
Feb 13, 2023

Conversation

marcello33
Copy link
Contributor

Description

This PR changes the behaviour of express-cli and matic-cli to run devnets only behind Bastillion and VPN.
It also makes usage of DNS instead of public IPv4 addresses and creates a secret.tfvars file to store Bastillion and VPN IPs to avoid exposing them.
Default configurations for docker and remote setup have been adjusted accordingly.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Breaking changes

Going forward, express-cli and matic-cli will only work behind Bastillion and VPN IPs, unless different configs are specified in secret.tfvars file.

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 requested review from a team and sshrihar February 10, 2023 14:53
@cffls
Copy link
Contributor

cffls commented Feb 10, 2023

Will this change affect users, e.g. third party developers, who don't have vpn or bastions?

@marcello33
Copy link
Contributor Author

marcello33 commented Feb 10, 2023

They'd need to change the secret.tfvars and add their own IPs @cffls
That can be also set to 0.0.0.0/0 and traffic will be open as it used to be before this PR

@marcello33 marcello33 merged commit f3d158e into master Feb 13, 2023
@pratikspatil024 pratikspatil024 deleted the mardizzone/POS-1058 branch February 13, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants