-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mardizzone/POS-1242: ci implementation and minor fixes #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcello33
changed the title
mardizzone/POS-1242 [WIP]
mardizzone/POS-1242: ci implementation and minor fixes
Feb 16, 2023
Raneet10
approved these changes
Feb 20, 2023
0xsharma
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the
express-cli
ci which executes the following steps:prettier
andlint
matic-cli
and create its.env
filesecret.tfvars
so that only the runner can connect to devnet's port 22aws
credentials and useMaticCLIGitHubActionsRole
to access AWS profile via OIDCaws key-pair
to connect to remote devnetnode 16.17.1
and installnpm
dependenciesinit
andstart
the devnet usingterraform
andexpress-cli
commands--send-state-sync
and--monitor exit
commands--destroy
the devnetaws key-pair
The ci will run on every PR and will fail if any of the above mentioned steps fails.
In either cases of success or fail, the devnet will be destroyed and the key-pair deleted to reduce infrastructure costs.
Also, it addresses the following changes:
SNYK-JS-ANSIREGEX-1583908
policy related to security issue due tolistr
upgradeweb3
library to latest version--monitor
command to exit in case of successful smoke tests executionterraform
configs to match the creator of the devnetChanges
Breaking changes
Please complete this section if any breaking changes have been made, otherwise delete it
Checklist
Testing