Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mardizzone/POS-1242: ci implementation and minor fixes #156

Merged
merged 21 commits into from
Feb 21, 2023

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Feb 15, 2023

Description

This PR implements the express-cli ci which executes the following steps:

  • run prettier and lint
  • checkout matic-cli and create its .env file
  • get GH action runner IP and create secret.tfvars so that only the runner can connect to devnet's port 22
  • configure aws credentials and use MaticCLIGitHubActionsRole to access AWS profile via OIDC
  • create aws key-pair to connect to remote devnet
  • setup node 16.17.1 and install npm dependencies
  • init and start the devnet using terraform and express-cli commands
  • run smoke tests with --send-state-sync and --monitor exit commands
  • --destroy the devnet
  • delete the aws key-pair

The ci will run on every PR and will fail if any of the above mentioned steps fails.
In either cases of success or fail, the devnet will be destroyed and the key-pair deleted to reduce infrastructure costs.

Also, it addresses the following changes:

  • remove SNYK-JS-ANSIREGEX-1583908 policy related to security issue due to listr upgrade
  • upgrade web3 library to latest version
  • adapt --monitor command to exit in case of successful smoke tests execution
  • bugfix for certificate cross name/path validation check
  • rename of terraform configs to match the creator of the devnet

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33 marcello33 changed the title mardizzone/POS-1242 [WIP] mardizzone/POS-1242: ci implementation and minor fixes Feb 16, 2023
@marcello33 marcello33 requested a review from a team February 16, 2023 12:22
@marcello33 marcello33 merged commit f9706c3 into master Feb 21, 2023
@marcello33 marcello33 deleted the mardizzone/POS-1242 branch November 16, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants