Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chg: fix heimdall chain id #233

Closed
wants to merge 1 commit into from
Closed

Conversation

marcello33
Copy link
Contributor

Description

This PR adapts matic-cli due to changes in maticnetwork/heimdall#1169

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Breaking changes

With the upgrade of cosmos-sdk, --chain-id is now called --chain to fix its empty value in heimdall REST server, fixed by this PR based on this work

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Cross repository changes

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

@marcello33
Copy link
Contributor Author

Closing as maticnetwork/heimdall#1169 is closed too

@marcello33 marcello33 closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant