Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mardizzone/docker support #79

Merged
merged 23 commits into from
Oct 21, 2022
Merged

Mardizzone/docker support #79

merged 23 commits into from
Oct 21, 2022

Conversation

marcello33
Copy link
Contributor

@marcello33 marcello33 commented Oct 20, 2022 •
edited
Loading

Description

This PR provides express-cli and matic-cli with support for docker devnets. It also adjusts the --send-state-sync and --monitor commands to have smoke tests on dockerized environments.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Manual tests

Performed remote docker and remote setups with both express-cli and matic-cli. Ran smoke tests and stress tests.

cffls and others added 21 commits June 21, 2022 22:36
@cffls
v0.3.0 migration
59befa6
@pratikspatil024
updated changed flags (bor/pull/451)
e2bb951
@pratikspatil024
addressed comments
41c8454
@temaniarpit27
Merge pull request #46 from pratikpatil024/v0.3.0-dev
2ed88f1 
Updated changed flags (bor/pull/451)
@pratikspatil024
bug fixed and added --identity flag
e47e3cb
@pratikspatil024
Merge pull request #48 from pratikpatil024/fix-name-flag
1bd4455 
Bug fixed and added identity flag
@pratikspatil024
Revert "Bug fixed and added identity flag"
0dd32d7
@pratikspatil024
Revert "Updated changed flags (bor/pull/451)"
a43911b
@pratikspatil024
Merge pull request #49 from maticnetwork/revert-48-fix-name-flag
bab4496 
Revert "Bug fixed and added identity flag"
@pratikspatil024
Merge pull request #50 from maticnetwork/revert-46-v0.3.0-dev
27a3df9 
Revert "Updated changed flags (bor/pull/451)"
@pratikspatil024
(revert) changed --identity to --name
cb5951c
@pratikspatil024
changed flags back again (#51)
9ad3ddc 
* changed flags back again

* addressed comment

* minor change
@cffls
Minor fix
2e26663
@temaniarpit27
fix issues
06377bd
@manav2401 @cffls
add miner.etherbase in start.sh (#55)
f0b953b
@cffls
Enable bor wallet so integration test is able to check the balance of…
c77ccb6 
… the account
@temaniarpit27
default develop
642be2d
@marcello33
dev: add: docker support
5c8093a
@marcello33
dev: merge v0.3.0-dev branch
5df7eac
@marcello33
dev: add: docker setup smoke tests
7383707
@marcello33
dev: chg: minor changes to env vars
aa9fb88
@marcello33 marcello33 requested a review from a team October 20, 2022 17:47
cffls
cffls approved these changes Oct 21, 2022
View reviewed changes
configs/devnet/docker-setup-config.yaml Outdated Show resolved Hide resolved
@marcello33 marcello33 merged commit af2d80f into master Oct 21, 2022
@marcello33 marcello33 deleted the mardizzone/docker-support branch October 27, 2022 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cffls cffls cffls approved these changes

@Raneet10 Raneet10 Raneet10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@marcello33 @Raneet10 @cffls @pratikspatil024 @temaniarpit27 @manav2401