Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallelize installation of dependencies in remote VMs #82

Merged
merged 18 commits into from
Oct 25, 2022
Merged

Parallelize installation of dependencies in remote VMs #82

merged 18 commits into from
Oct 25, 2022

Conversation

Raneet10
Copy link
Member

@Raneet10 Raneet10 commented Oct 21, 2022 •
edited
Loading

Description

This PR parallelizes the installation of dependencies in remote machines, which should speed up the devnet setup process when spinning up a large number of nodes.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • New test case for remote devnet

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai

Manual tests

Spun up a 3 node devnet to test.

@Raneet10 Raneet10 requested a review from a team October 21, 2022 14:15
marcello33
marcello33 requested changes Oct 21, 2022
View reviewed changes
configs/devnet/docker-setup-config.yaml Outdated Show resolved Hide resolved
configs/devnet/remote-setup-config.yaml Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
marcello33
marcello33 reviewed Oct 24, 2022
View reviewed changes
src/express/commands/start.js Outdated Show resolved Hide resolved
src/express/commands/start.js Outdated Show resolved Hide resolved
@marcello33 marcello33 merged commit 9f1eec5 into master Oct 25, 2022
@jdkanani jdkanani deleted the raneet10/pos-928 branch October 25, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcello33 marcello33 marcello33 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Raneet10 @marcello33