DVT-153 Node 16 Upgrade #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbyz
commented
Oct 31, 2022
src/setup/bor/index.js
Outdated
| @@ -22,7 +22,7 @@ export class Bor { | |||
| this.config = config; | |||
|
|
|||
| this.repositoryName = "bor"; | |||
| this.repositoryBranch = options.repositoryBranch || "develop"; | |||
| this.repositoryBranch = "jesse-test"; | |||
There was a problem hiding this comment.
should be reverted to original after merge
gatsbyz
commented
Oct 31, 2022
src/setup/contracts/index.js
Outdated
| @@ -11,7 +11,7 @@ export class Contracts { | |||
| this.config = config; | |||
|
|
|||
| this.repositoryName = "contracts"; | |||
| this.repositoryBranch = options.repositoryBranch || "master"; | |||
| this.repositoryBranch = "jesse-test"; | |||
There was a problem hiding this comment.
should be reverted to original after merge
gatsbyz
commented
Oct 31, 2022
src/setup/devnet/index.js
Outdated
|
|
||
| shell.exec(`mkdir -p ${this.config.targetDirectory}`) | ||
| shell.exec(`chmod 777 -R ${this.config.targetDirectory}`) | ||
| console.log('this.config.targetDirectory', this.config.targetDirectory); |
There was a problem hiding this comment.
The log i get is
this.config.targetDirectory /home/ubuntu/matic-cli/devnet
So I guess we need to restore /var/lib/heimdall
gatsbyz
commented
Oct 31, 2022
src/setup/genesis/index.js
Outdated
| @@ -20,7 +20,7 @@ export class Genesis { | |||
| this.config = config; | |||
|
|
|||
| this.repositoryName = this.name; | |||
| this.repositoryBranch = options.repositoryBranch || "master"; | |||
| this.repositoryBranch = "jesse-test"; | |||
There was a problem hiding this comment.
should be reverted to original after merge
gatsbyz
commented
Oct 31, 2022
src/setup/index.js
Outdated
| @@ -22,9 +22,11 @@ borCmd.action(bor); | |||
| const ganacheCmd = new Command("ganache"); | |||
| ganacheCmd.action(ganache); | |||
|
|
|||
| console.log("hello123") | |||
There was a problem hiding this comment.
You can proceed removing it :) Thanks
marcello33
requested changes
Nov 3, 2022
src/setup/devnet/index.js
Outdated
|
|
||
| shell.exec(`mkdir -p ${this.config.targetDirectory}`) | ||
| shell.exec(`chmod 777 -R ${this.config.targetDirectory}`) | ||
| console.log('this.config.targetDirectory', this.config.targetDirectory); |
There was a problem hiding this comment.
The log i get is
this.config.targetDirectory /home/ubuntu/matic-cli/devnet
So I guess we need to restore /var/lib/heimdall
src/setup/index.js
Outdated
| @@ -22,9 +22,11 @@ borCmd.action(bor); | |||
| const ganacheCmd = new Command("ganache"); | |||
| ganacheCmd.action(ganache); | |||
|
|
|||
| console.log("hello123") | |||
There was a problem hiding this comment.
You can proceed removing it :) Thanks
src/setup/index.js
Outdated
| const localnetCmd = new Command("localnet"); | ||
| localnetCmd.action(localnet); | ||
|
|
||
| console.log("gatsby123") |
There was a problem hiding this comment.
You can proceed removing it :) Thanks
0xsharma
force-pushed
the
jesse-test
branch
6 times, most recently
from
869224c
to
b98804b
Compare
marcello33
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove
ganache-cliand useganacheand update scriptsremove
moonwalkeras a dependency