Change input validation length for longer licence key #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -52,7 +52,7 @@ | |||
| <label for="<?php echo esc_attr( GeolocationSettings::FORM_NAME ); ?>"><?php esc_html_e( 'MaxMind License Key', 'matomo' ); ?></label>: | |||
| </th> | |||
| <td> | |||
| <input size="20" type="text" maxlength="20" | |||
| <input size="40" type="text" maxlength="50" | |||
There was a problem hiding this comment.
@lance-matomo Here setting the size to 50 looks more clean
With size 50
With size 40
AltamashShaikh
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
@lance-matomo The changes looks good, left just 1 comment not important to implement
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The new Maxmind Licence keys are longer, the test one I generated was 40 chars. I made the limit 50 just in case there is any slight variation.
Review