Skip to content

Commit

Permalink
change mysql column type for new installs for log_action.name and log…
Browse files Browse the repository at this point in the history
…_conversion.url (#14848)
  • Loading branch information
tsteur authored and diosmosis committed Sep 3, 2019
1 parent ea18198 commit bb145db
Show file tree
Hide file tree
Showing 2 changed files with 49 additions and 2 deletions.
4 changes: 2 additions & 2 deletions core/Db/Schema/Mysql.php
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ public function getTablesCreateSql()

'log_action' => "CREATE TABLE {$prefixTables}log_action (
idaction INTEGER(10) UNSIGNED NOT NULL AUTO_INCREMENT,
name TEXT,
name VARCHAR(65000),
hash INTEGER(10) UNSIGNED NOT NULL,
type TINYINT UNSIGNED NULL,
url_prefix TINYINT(2) NULL,
Expand Down Expand Up @@ -209,7 +209,7 @@ public function getTablesCreateSql()
buster int unsigned NOT NULL,
idorder varchar(100) default NULL,
items SMALLINT UNSIGNED DEFAULT NULL,
url text NOT NULL,
url VARCHAR(65000) NOT NULL,
PRIMARY KEY (idvisit, idgoal, buster),
UNIQUE KEY unique_idsite_idorder (idsite, idorder),
INDEX index_idsite_datetime ( idsite, server_time )
Expand Down
47 changes: 47 additions & 0 deletions core/Updates/4.0.0-b1.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php
/**
* Piwik - free/libre analytics platform
*
* @link https://matomo.org
* @license http://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*
*/

namespace Piwik\Updates;

use Piwik\Updater;
use Piwik\Updates as PiwikUpdates;
use Piwik\Updater\Migration;
use Piwik\Updater\Migration\Factory as MigrationFactory;

/**
* Update for version 4.0.0-b1.
*/
class Updates_4_0_0_b1 extends PiwikUpdates
{
/**
* @var MigrationFactory
*/
private $migration;

public function __construct(MigrationFactory $factory)
{
$this->migration = $factory;
}

public function getMigrations(Updater $updater)
{
$migration1 = $this->migration->db->changeColumnType('log_action', 'name', 'VARCHAR(65000)');
$migration2 = $this->migration->db->changeColumnType('log_conversion', 'url', 'VARCHAR(65000) NOT NULL');

return array(
$migration1,
$migration2,
);
}

public function doUpdate(Updater $updater)
{
$updater->executeMigrations(__FILE__, $this->getMigrations($updater));
}
}

0 comments on commit bb145db

Please sign in to comment.