-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jQuery to 3.6.3 #19989
Update jQuery to 3.6.3 #19989
Conversation
ffa99e0
to
6f9c0c5
Compare
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
c4c2099
to
b0f8588
Compare
8c7b1c1
to
9bfcfb9
Compare
044ec1a
to
358ce04
Compare
For some reason the UI tests have started to fail more often on this branch. I'm not yet sure how this is related to jQuery 3.6. Tried adding some more debugging to the tests, but might need to investigate the failures bit further... |
4c06721
to
7deab51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UI tests look good, (except for some randoms which are present on other branches). I did some manual testing moving around the UI and checking the browser console, but didn't encounter any issues 👍
- Functional review done
- Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
- Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
- Security review done
- Wording review done
- Code review done
- Test updated Tests were added if useful/possible
- Note added Reviewed for breaking changes
- Developer changelog updated if needed
- Documentation added if needed
- Existing documentation updated if needed
Description:
replaces #19945
Review