Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #19850 removing couple columns which makes doesnt make sense #21405

Closed
wants to merge 1 commit into from
Closed

Issue #19850 removing couple columns which makes doesnt make sense #21405

wants to merge 1 commit into from

Conversation

dzhibas
Copy link

@dzhibas dzhibas commented Oct 16, 2023

Description:

Just like mentioned in issue #19850 removing user amount and unique visitors from columns

image

Review

This was referenced Oct 16, 2023
Closed
Closed
@github-actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Oct 31, 2023
@michalkleiner
Copy link
Contributor

Hi @dzhibas, thank you for taking the time to contribute your code and opening the PR.

If you look at the SystemTestsCore, SystemTestsPlugins and UI tests failures, there are other areas of the codebase that need adjusting when removing columns from the Users data table.

Is it ok for you to have a look and adjust the tests as well?

@michalkleiner michalkleiner removed the Stale The label used by the Close Stale Issues action label Nov 12, 2023
@michalkleiner michalkleiner added this to the 5.1.0 milestone Nov 12, 2023
@michalkleiner michalkleiner added Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. c: Design / UI For issues that impact Matomo's user interface or the design overall. labels Nov 12, 2023
@dzhibas
Copy link
Author

dzhibas commented Nov 13, 2023

sure will fix those

@github-actions GitHub Actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Jan 10, 2024
@michalkleiner michalkleiner removed Stale The label used by the Close Stale Issues action Stale for long The label used by the Close Stale Issues action labels Jan 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Jan 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers

@github-actions github-actions bot added the Stale for long The label used by the Close Stale Issues action label Mar 9, 2024
@michalkleiner
Copy link
Contributor

Hi @dzhibas, are you still interesting in tweaking the tests? It's ok if not, just let us know and we can close the PR.

@github-actions github-actions bot removed Stale for long The label used by the Close Stale Issues action Stale The label used by the Close Stale Issues action labels Mar 23, 2024
@sgiehl sgiehl added Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users. labels Mar 25, 2024
@sgiehl sgiehl removed this from the 5.1.0 milestone Mar 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'.

@github-actions github-actions bot added the Stale The label used by the Close Stale Issues action label Apr 9, 2024
@sgiehl
Copy link
Member

sgiehl commented Apr 9, 2024

Closing for now due to inactivity. @dzhibas If you are keen to finish the work, feel free to do so and reopen the PR once your done.

@sgiehl sgiehl closed this Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Pull Request WIP Indicates the current pull request is still work in progress and not ready yet for a review. Stale The label used by the Close Stale Issues action Waiting for user feedback Indicates the Matomo team is waiting for feedback from the author or other users.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dzhibas @michalkleiner @sgiehl