Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply coding style around FunctionCallSignature #6 #21932

Merged
merged 1 commit into from Feb 15, 2024
Merged

Apply coding style around FunctionCallSignature #6 #21932

merged 1 commit into from Feb 15, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Feb 13, 2024 •
edited

Description:

refs #21926

Note: The PHPCS failure in the PR is expected. It should succeed once all other PRs were merged.

Review

@sgiehl sgiehl added c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Needs Review PRs that need a code review Technical debt Issues the will help to reduce technical debt labels Feb 13, 2024
@sgiehl sgiehl added this to the 5.0.3 milestone Feb 13, 2024
@sgiehl sgiehl requested a review from a team February 13, 2024 17:26
@caddoo caddoo merged commit 2d83ba4 into psr12_funccallsig Feb 15, 2024
20 of 25 checks passed
@caddoo caddoo deleted the psr12_funccallsig_6 branch February 15, 2024 01:46
sgiehl added a commit that referenced this pull request Feb 15, 2024
@sgiehl
Apply coding style around FunctionCallSignature #6 (#21932)
b422e05
sgiehl added a commit that referenced this pull request Feb 15, 2024
@sgiehl
[Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* (#21926
e61eb91 
)

* [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.*

* Apply coding style around FunctionCallSignature #1 (#21927)

* Apply coding style around FunctionCallSignature #2 (#21928)

* Apply coding style around FunctionCallSignature #3 (#21929)

* Apply coding style around FunctionCallSignature #4 (#21930)

* Apply coding style around FunctionCallSignature #5 (#21931)

* Apply coding style around FunctionCallSignature #6 (#21932)

* Apply coding style around FunctionCallSignature #7 (#21933)

* Apply coding style around FunctionCallSignature #8 (#21934)

* Apply coding style around FunctionCallSignature #9 (#21935)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caddoo caddoo caddoo approved these changes

Assignees
No one assigned
Labels
c: Tests & QA For issues related to automated tests or making it easier to QA & test issues. Needs Review PRs that need a code review not-in-changelog For issues or pull requests that should not be included in our release changelog on matomo.org. Technical debt Issues the will help to reduce technical debt
Projects
None yet
Milestone
5.0.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgiehl @caddoo