New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SitesManager plugins: added group managment to admin UI #4

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@shesek
Contributor

shesek commented Aug 14, 2012

Just some simple additions to make the "group" field editable via the SitesManager admin UI. This seems to have gotten stuck for quite some time on http://dev.piwik.org/trac/ticket/2174, would be great if you could merge it into core.

@robocoder

This comment has been minimized.

Show comment
Hide comment
@robocoder

robocoder Aug 26, 2012

Contributor

Thanks. The project is still using Trac+svn, so I have linked the Trac ticket to your patch.

Contributor

robocoder commented Aug 26, 2012

Thanks. The project is still using Trac+svn, so I have linked the Trac ticket to your patch.

@robocoder robocoder closed this Aug 26, 2012

@halfdan halfdan referenced this pull request Jul 1, 2009

Closed

PHP 5.3 breaks Piwik #844

@mikeSimonson mikeSimonson referenced this pull request Aug 10, 2009

Closed

sql bug #915

@lehrer lehrer referenced this pull request Sep 16, 2010

Closed

Whois Live Plugin #1317

mnapoli added a commit that referenced this pull request Jun 3, 2015

Merge pull request #8008 from piwik/test_env_di_5
Injection Inception, Change #4: Using DI as primary mechanism in setting up Test environment

tsteur added a commit that referenced this pull request Jul 4, 2018

Destroy database connection only if it has a connection already
Otherwise it would create a connection just to destroy it. Noticed this when my tests were failing because of this.

```
Failed to setup fixture: TEST INITIALIZATION FAILED: SQLSTATE[HY000] [1049] Unknown database 'piwik_tests'
#0 libs/Zend/Db/Adapter/Pdo/Mysql.php(109): Zend_Db_Adapter_Pdo_Abstract->_connect()
#1 core/Db/Adapter/Pdo/Mysql.php(96): Zend_Db_Adapter_Pdo_Mysql->_connect()
#2 core/Db/Adapter/Pdo/Mysql.php(74): Piwik\Db\Adapter\Pdo\Mysql->_connect()
#3 core/Db/Adapter.php(51): Piwik\Db\Adapter\Pdo\Mysql->getConnection()
#4 core/Db.php(122): Piwik\Db\Adapter::factory('PDO\\MYSQL', Array)
#5 core/Db.php(54): Piwik\Db::createDatabaseObject()
#6 core/DbHelper.php(142): Piwik\Db::get()
#7 core/Db.php(144): Piwik\DbHelper::disconnectDatabase()
#8 tests/PHPUnit/Framework/Fixture.php(869): Piwik\Db::destroyDatabaseObject()
#9 tests/PHPUnit/Framework/Fixture.php(227): Piwik\Tests\Framework\Fixture::connectWithoutDatabase()
#10 tests/PHPUnit/Framework/TestCase/SystemTestCase.php(76): Piwik\Tests\Framework\Fixture->performSetUp()
#11 tests/PHPUnit/Framework/TestCase/IntegrationTestCase.php(61): Piwik\Tests\Framework\TestCase\SystemTestCase::setUpBeforeClass()
```

diosmosis added a commit that referenced this pull request Jul 8, 2018

Destroy database connection only if it has a connection already (#13132)
Otherwise it would create a connection just to destroy it. Noticed this when my tests were failing because of this.

```
Failed to setup fixture: TEST INITIALIZATION FAILED: SQLSTATE[HY000] [1049] Unknown database 'piwik_tests'
#0 libs/Zend/Db/Adapter/Pdo/Mysql.php(109): Zend_Db_Adapter_Pdo_Abstract->_connect()
#1 core/Db/Adapter/Pdo/Mysql.php(96): Zend_Db_Adapter_Pdo_Mysql->_connect()
#2 core/Db/Adapter/Pdo/Mysql.php(74): Piwik\Db\Adapter\Pdo\Mysql->_connect()
#3 core/Db/Adapter.php(51): Piwik\Db\Adapter\Pdo\Mysql->getConnection()
#4 core/Db.php(122): Piwik\Db\Adapter::factory('PDO\\MYSQL', Array)
#5 core/Db.php(54): Piwik\Db::createDatabaseObject()
#6 core/DbHelper.php(142): Piwik\Db::get()
#7 core/Db.php(144): Piwik\DbHelper::disconnectDatabase()
#8 tests/PHPUnit/Framework/Fixture.php(869): Piwik\Db::destroyDatabaseObject()
#9 tests/PHPUnit/Framework/Fixture.php(227): Piwik\Tests\Framework\Fixture::connectWithoutDatabase()
#10 tests/PHPUnit/Framework/TestCase/SystemTestCase.php(76): Piwik\Tests\Framework\Fixture->performSetUp()
#11 tests/PHPUnit/Framework/TestCase/IntegrationTestCase.php(61): Piwik\Tests\Framework\TestCase\SystemTestCase::setUpBeforeClass()
```

InfinityVoid added a commit to InfinityVoid/matomo that referenced this pull request Oct 11, 2018

Destroy database connection only if it has a connection already (mato…
…mo-org#13132)

Otherwise it would create a connection just to destroy it. Noticed this when my tests were failing because of this.

```
Failed to setup fixture: TEST INITIALIZATION FAILED: SQLSTATE[HY000] [1049] Unknown database 'piwik_tests'
#0 libs/Zend/Db/Adapter/Pdo/Mysql.php(109): Zend_Db_Adapter_Pdo_Abstract->_connect()
#1 core/Db/Adapter/Pdo/Mysql.php(96): Zend_Db_Adapter_Pdo_Mysql->_connect()
matomo-org#2 core/Db/Adapter/Pdo/Mysql.php(74): Piwik\Db\Adapter\Pdo\Mysql->_connect()
matomo-org#3 core/Db/Adapter.php(51): Piwik\Db\Adapter\Pdo\Mysql->getConnection()
matomo-org#4 core/Db.php(122): Piwik\Db\Adapter::factory('PDO\\MYSQL', Array)
matomo-org#5 core/Db.php(54): Piwik\Db::createDatabaseObject()
matomo-org#6 core/DbHelper.php(142): Piwik\Db::get()
matomo-org#7 core/Db.php(144): Piwik\DbHelper::disconnectDatabase()
matomo-org#8 tests/PHPUnit/Framework/Fixture.php(869): Piwik\Db::destroyDatabaseObject()
matomo-org#9 tests/PHPUnit/Framework/Fixture.php(227): Piwik\Tests\Framework\Fixture::connectWithoutDatabase()
matomo-org#10 tests/PHPUnit/Framework/TestCase/SystemTestCase.php(76): Piwik\Tests\Framework\Fixture->performSetUp()
matomo-org#11 tests/PHPUnit/Framework/TestCase/IntegrationTestCase.php(61): Piwik\Tests\Framework\TestCase\SystemTestCase::setUpBeforeClass()
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment