-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3317] export_as_image_icon setting has no effect on widget #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2011
Closed
Closed
This was referenced Jul 22, 2010
ghost
mentioned this pull request
Feb 13, 2012
This was referenced Aug 3, 2012
This was referenced Aug 16, 2012
This was referenced Jan 10, 2022
This was referenced May 2, 2023
Open
2 tasks
This was referenced Oct 2, 2023
Closed
4 tasks
sgiehl
added a commit
that referenced
this pull request
Feb 13, 2024
caddoo
pushed a commit
that referenced
this pull request
Feb 15, 2024
sgiehl
added a commit
that referenced
this pull request
Feb 15, 2024
sgiehl
added a commit
that referenced
this pull request
Feb 15, 2024
) * [Coding Style] Enable rules PSR2.Methods.FunctionCallSignature.* * Apply coding style around FunctionCallSignature #1 (#21927) * Apply coding style around FunctionCallSignature #2 (#21928) * Apply coding style around FunctionCallSignature #3 (#21929) * Apply coding style around FunctionCallSignature #4 (#21930) * Apply coding style around FunctionCallSignature #5 (#21931) * Apply coding style around FunctionCallSignature #6 (#21932) * Apply coding style around FunctionCallSignature #7 (#21933) * Apply coding style around FunctionCallSignature #8 (#21934) * Apply coding style around FunctionCallSignature #9 (#21935)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Tests pass: -
Fixes the following tickets: #3317
Todo: -
License of the code: MIT
Use case:
Using Widgetize-Plugin to display certain widgets on a website:
The show_export_as_image_icon setting has no effect, because the value (first set in parent class from request parameters) is overwritten in core/ViewDataTable/GenerateGraphHTML.php
I don't see why this shouldn't be allowed here. The patch fixes this problem.